Skip to content

feat: handle human size prefixes #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

iTrooz
Copy link

@iTrooz iTrooz commented Jun 14, 2025

this PR allows you to specify human sizes in the configuration. For example:

[dist]
toolchain_cache_size = "5G"

[cache.disk]
size = "20G"

As a bonus, I also added for lowercase sizes, e.g. "2k"

@iTrooz iTrooz changed the title handle lower case size prefixes feat: handle lower case size prefixes Jun 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2025

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (7025295) to head (0dafd04).

Files with missing lines Patch % Lines
src/config.rs 56.75% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
+ Coverage   67.06%   67.18%   +0.11%     
==========================================
  Files          64       64              
  Lines       34718    34747      +29     
==========================================
+ Hits        23285    23345      +60     
+ Misses      11433    11402      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iTrooz iTrooz changed the title feat: handle lower case size prefixes feat: handle size prefixes Jun 29, 2025
@iTrooz iTrooz changed the title feat: handle size prefixes feat: handle human size prefixes Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants