Don't use CARGO_BUILD_JOBS in hash keys #2328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Perhaps we can discuss what other variables should be excluded or whether sccache could have a knob that allows the user to select which environment variables to exclude from the key, though I understand that having a knob may complicate things unnecessarily) |
drahnr
approved these changes
Feb 19, 2025
`CARGO_BUILD_JOBS` only affects Cargo's parallelism, not rustc's outputs, so it can be safely excluded from the cache key. This enables better cache reutilization when building from environments with different number of CPUs.
sylvestre
force-pushed
the
exclude-CARGO_BUILD_JOBS-from-cache-key
branch
from
c2851b2 to
85eabc0
Compare
|
I think a long-term solution would be to have a meta-key, that allows to exclude arbitrary environment variables from being included. Out of scope for this PR though. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 65 65
Lines 36214 36221 +7
=======================================
+ Hits 25923 25930 +7
Misses 10291 10291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARGO_BUILD_JOBSonly affects Cargo's parallelism, not rustc's outputs, so it can be safely excluded from the cache key.This enables better cache reutilization when building from environments with different number of CPUs.
I ran into this while experimenting with sccache on a containerized system where a library can be shared/compiled between different job sizes, and was surprised that I was getting cache misses for those libraries.
Given how small the change is, I figured opening the PR wouldn't hurt, but please let me know if you prefer me to move this to an issue for further discussion before actually having the PR reviewed.