Skip to content

Draft PR for discussion: transition to CSS varaibles only for type #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Draft PR for discussion: transition to CSS varaibles only for type #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a86de9e
typography v1
Mar 21, 2025
25e49a6
remove display aliases
Mar 25, 2025
a0919a8
Add font family declaration
Apr 3, 2025
c44afaa
review fixes
May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
* Dropped support for font-sizes in pixels, all font-sizes are in rem now.
* Removed `text-display-*` mixins. See migration notes for version 11.0.2.


# HEAD

* **assets:** Update @mozilla-protocol/assets to 6.1.1
Expand All @@ -10,6 +14,7 @@

* Un-customized implementations of the footer will not break. If you have made customizations review it at all breakpoints.


# 21.0.0

## Features
Expand Down
32 changes: 0 additions & 32 deletions assets/sass/protocol/base/utilities/_titles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,73 +10,41 @@
.mzp-u-title-2xl {
@include text-title-2xl;
font-family: $title-font-family;
Copy link
Contributor Author

@stephaniehobson stephaniehobson Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe font-family should be part of the @include text-title-n declaration?


@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-xl {
@include text-title-xl;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-lg {
@include text-title-lg;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-md {
@include text-title-md;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-sm {
@include text-title-sm;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-xs {
@include text-title-xs;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-2xs {
@include text-title-2xs;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

.mzp-u-title-3xs {
@include text-title-3xs;
font-family: $title-font-family;

@supports (--css: variables) {
font-family: var(--title-font-family);
}
}

// Utility class for centered text.
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_sticky-promo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ $logos: (
}

.mzp-c-sticky-promo-title {
@include text-display-xs;
@include text-title-xs;
margin-bottom: $spacing-xl;
}

Expand Down
1 change: 0 additions & 1 deletion assets/sass/protocol/includes/forms/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ $line-height-shim: 0.15em; // two elements with text appear to have more space b
@include text-body-sm;
display: block;
font-weight: bold;
line-height: $text-body-line-height;
margin: 0;
padding-bottom: $label-v-spacing;

Expand Down
Loading