Skip to content

ci: Disable systemd unified cgroups on GCP #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (5e018ba) to head (117c818).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   94.89%   94.91%   +0.02%     
==========================================
  Files         115      115              
  Lines       34286    34286              
  Branches    34286    34286              
==========================================
+ Hits        32535    32543       +8     
+ Misses       1744     1734      -10     
- Partials        7        9       +2     
Components Coverage Δ
neqo-common 97.10% <ø> (ø)
neqo-crypto 89.64% <ø> (ø)
neqo-http3 93.71% <ø> (ø)
neqo-qpack 95.45% <ø> (ø)
neqo-transport 96.00% <ø> (+0.04%) ⬆️
neqo-udp 89.85% <ø> (ø)

Copy link

Client/server transfer results

Performance differences relative to 5e018ba.

Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.

Client vs. server (params) Mean ± σ Min Max MiB/s ± σ Δ main Δ main
google vs. google 450.9 ± 4.8 444.8 462.6 71.0 ± 6.7
google vs. neqo (cubic, paced) 270.5 ± 4.6 261.4 278.5 118.3 ± 7.0 -0.6 -0.2%
msquic vs. msquic 128.5 ± 16.5 106.4 203.8 249.1 ± 1.9
msquic vs. neqo (cubic, paced) 149.9 ± 26.8 121.5 245.7 213.5 ± 1.2 -6.6 -4.2%
neqo vs. google (cubic, paced) 751.4 ± 4.4 745.3 763.5 42.6 ± 7.3 0.5 0.1%
neqo vs. msquic (cubic, paced) 155.8 ± 5.4 148.6 178.3 205.3 ± 5.9 0.8 0.5%
neqo vs. neqo (cubic) 91.6 ± 4.9 83.1 109.1 349.2 ± 6.5 0.9 1.0%
neqo vs. neqo (cubic, paced) 94.0 ± 4.4 83.8 106.6 340.5 ± 7.3 💔 2.6 2.8%
neqo vs. neqo (reno) 91.6 ± 4.7 81.8 104.8 349.5 ± 6.8 0.8 0.9%
neqo vs. neqo (reno, paced) 90.3 ± 4.5 82.0 104.8 354.3 ± 7.1 💚 -2.2 -2.3%
neqo vs. quiche (cubic, paced) 193.7 ± 4.9 184.6 203.1 165.2 ± 6.5 💔 2.2 1.1%
neqo vs. s2n (cubic, paced) 217.1 ± 3.8 210.9 225.3 147.4 ± 8.4 💚 -1.6 -0.7%
quiche vs. neqo (cubic, paced) 160.2 ± 6.0 149.8 193.8 199.8 ± 5.3 1.4 0.9%
quiche vs. quiche 148.1 ± 4.8 138.7 162.5 216.0 ± 6.7
s2n vs. neqo (cubic, paced) 171.7 ± 4.8 162.6 185.5 186.4 ± 6.7 -0.8 -0.5%
s2n vs. s2n 248.1 ± 29.6 231.5 352.7 129.0 ± 1.1

Download data for profiler.firefox.com or download performance comparison data.

Copy link

Benchmark results

Performance differences relative to 5e018ba.

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [198.23 ms 198.63 ms 199.13 ms]
       thrpt:  [502.18 MiB/s 503.45 MiB/s 504.46 MiB/s]
change:
       time:   [−0.1492% +0.1171% +0.3744%] (p = 0.42 > 0.05)
       thrpt:  [−0.3730% −0.1170% +0.1494%]

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [303.24 ms 304.81 ms 306.37 ms]
       thrpt:  [32.640 Kelem/s 32.808 Kelem/s 32.977 Kelem/s]
change:
       time:   [−0.2616% +0.4848% +1.2390%] (p = 0.21 > 0.05)
       thrpt:  [−1.2239% −0.4825% +0.2623%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold.
       time:   [27.832 ms 27.943 ms 28.066 ms]
       thrpt:  [35.630   B/s 35.788   B/s 35.930   B/s]
change:
       time:   [−1.6389% −0.8712% −0.0924%] (p = 0.03 < 0.05)
       thrpt:  [+0.0925% +0.8789% +1.6662%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: Change within noise threshold.
       time:   [624.01 ms 627.91 ms 631.64 ms]
       thrpt:  [158.32 MiB/s 159.26 MiB/s 160.25 MiB/s]
change:
       time:   [−1.6584% −0.9351% −0.1265%] (p = 0.02 < 0.05)
       thrpt:  [+0.1267% +0.9439% +1.6863%]

Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) low severe
7 (7.00%) low mild
2 (2.00%) high severe

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.813 µs 11.843 µs 11.881 µs]
       change: [−0.8293% −0.1300% +0.5663%] (p = 0.73 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low severe
6 (6.00%) low mild
1 (1.00%) high mild
7 (7.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0208 ms 3.0449 ms 3.0841 ms]
       change: [−0.3533% +0.4995% +2.1354%] (p = 0.48 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.997 µs 20.048 µs 20.105 µs]
       change: [−0.5687% −0.1486% +0.1855%] (p = 0.48 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
2 (2.00%) low severe
4 (4.00%) low mild
1 (1.00%) high mild
10 (10.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.0424 ms 5.0538 ms 5.0668 ms]
       change: [−0.4883% −0.0854% +0.2806%] (p = 0.65 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [8.2528 µs 8.2747 µs 8.3035 µs]
       change: [−0.6647% −0.1386% +0.4089%] (p = 0.63 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.5852 ms 1.5908 ms 1.5977 ms]
       change: [−0.8012% −0.1946% +0.3369%] (p = 0.51 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe

1000 streams of 1 bytes/multistream: No change in performance detected.
       time:   [27.149 ns 31.325 ns 39.480 ns]
       change: [−29.359% +0.6124% +43.579%] (p = 0.88 > 0.05)

Found 77 outliers among 500 measurements (15.40%)
32 (6.40%) high mild
45 (9.00%) high severe
Criterion.rs ERROR: Error in Gnuplot: line 0: Can't plot with an empty x range!

:
Criterion.rs ERROR: Error in Gnuplot:          line 0: Can't plot with an empty x range!
: No change in performance detected.

1000 streams of 1000 bytes/multistream
time: [26.859 ns 27.068 ns 27.299 ns]
change: [−1.8637% −0.7868% +0.3347%] (p = 0.17 > 0.05)

Found 93 outliers among 500 measurements (18.60%)
23 (4.60%) high mild
70 (14.00%) high severe
Criterion.rs ERROR: Error in Gnuplot: line 0: Can't plot with an empty x range!

: No change in performance detected.

coalesce_acked_from_zero 1+1 entries
time: [87.998 ns 88.308 ns 88.618 ns]
change: [−0.5836% −0.1186% +0.3515%] (p = 0.63 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
10 (10.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [105.40 ns 105.82 ns 106.28 ns]
       change: [−0.6504% +0.0147% +0.6349%] (p = 0.96 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [104.71 ns 105.04 ns 105.44 ns]
       change: [−0.8980% −0.3705% +0.0981%] (p = 0.15 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) low mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [88.686 ns 88.779 ns 88.893 ns]
       change: [−0.6689% +0.3264% +1.2730%] (p = 0.55 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [107.19 ms 107.26 ms 107.32 ms]
       change: [−1.1590% −0.8504% −0.6581%] (p = 0.00 < 0.05)

Found 21 outliers among 100 measurements (21.00%)
11 (11.00%) low mild
9 (9.00%) high mild
1 (1.00%) high severe

sent::Packets::take_ranges: No change in performance detected.
       time:   [7.9993 µs 8.2155 µs 8.4208 µs]
       change: [−2.6334% +3.8419% +13.334%] (p = 0.43 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
4 (4.00%) low severe
12 (12.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [37.414 ms 37.497 ms 37.580 ms]
       change: [−0.5382% −0.2241% +0.0868%] (p = 0.16 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [37.975 ms 38.089 ms 38.205 ms]
       change: [−1.1393% −0.7486% −0.3411%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [36.993 ms 37.081 ms 37.181 ms]
       change: [−0.3306% −0.0252% +0.2930%] (p = 0.88 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [38.835 ms 38.932 ms 39.034 ms]
       change: [−0.1587% +0.1892% +0.5474%] (p = 0.29 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

Download data for profiler.firefox.com or download performance comparison data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant