fix(http3): reduce visibility of internal functions #2802
Conversation
Mark functions not used in Firefox as pub(crate). This enables us to detect unused code and simplifies future refactorings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
- Coverage 94.91% 94.89% -0.03%
==========================================
Files 115 115
Lines 34286 34302 +16
Branches 34286 34302 +16
==========================================
+ Hits 32543 32551 +8
- Misses 1734 1744 +10
+ Partials 9 7 -2
|
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Benchmark resultsPerformance differences relative to 8d26554. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [198.23 ms 198.52 ms 198.81 ms]
thrpt: [503.00 MiB/s 503.74 MiB/s 504.47 MiB/s]
change:
time: [−0.2091% +0.0050% +0.2228%] (p = 0.97 > 0.05)
thrpt: [−0.2223% −0.0050% +0.2095%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [304.46 ms 305.99 ms 307.53 ms]
thrpt: [32.517 Kelem/s 32.681 Kelem/s 32.845 Kelem/s]
change:
time: [−0.2677% +0.4498% +1.1895%] (p = 0.23 > 0.05)
thrpt: [−1.1755% −0.4477% +0.2684%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [27.846 ms 27.979 ms 28.134 ms]
thrpt: [35.545 B/s 35.741 B/s 35.912 B/s]
change:
time: [−1.0191% −0.4101% +0.2856%] (p = 0.23 > 0.05)
thrpt: [−0.2848% +0.4118% +1.0296%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [626.68 ms 631.13 ms 635.40 ms]
thrpt: [157.38 MiB/s 158.45 MiB/s 159.57 MiB/s]
change:
time: [−1.5171% −0.6244% +0.2839%] (p = 0.20 > 0.05)
thrpt: [−0.2831% +0.6283% +1.5405%]
decode 4096 bytes, mask ff: No change in performance detected. time: [11.819 µs 11.865 µs 11.922 µs]
change: [−0.3179% +0.6032% +1.8831%] (p = 0.39 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0205 ms 3.0351 ms 3.0549 ms]
change: [−0.6075% +0.0112% +0.7878%] (p = 0.97 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.010 µs 20.064 µs 20.123 µs]
change: [−0.0996% +0.1087% +0.3476%] (p = 0.34 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0417 ms 5.0545 ms 5.0681 ms]
change: [−0.4522% −0.0721% +0.3294%] (p = 0.72 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2486 µs 8.2632 µs 8.2862 µs]
change: [−0.3577% −0.0714% +0.1967%] (p = 0.64 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5881 ms 1.5951 ms 1.6034 ms]
change: [−0.5365% +0.0845% +0.7087%] (p = 0.82 > 0.05)
1000 streams of 1 bytes/multistream: No change in performance detected. time: [27.706 ns 27.890 ns 28.083 ns]
change: [−1.3280% −0.3573% +0.6098%] (p = 0.48 > 0.05)
:Criterion.rs ERROR: Error in Gnuplot: line 0: Can't plot with an empty x range! : No change in performance detected.
:Criterion.rs ERROR: Error in Gnuplot: line 0: Can't plot with an empty x range! : Change within noise threshold.
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [106.42 ns 106.78 ns 107.15 ns]
change: [+0.2847% +0.9142% +1.6685%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [105.83 ns 106.44 ns 107.15 ns]
change: [+0.2248% +0.8304% +1.3550%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [89.650 ns 93.209 ns 101.14 ns]
change: [+0.3463% +3.6891% +9.4339%] (p = 0.14 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [107.66 ms 107.73 ms 107.80 ms]
change: [−1.2025% −0.9232% −0.7269%] (p = 0.00 < 0.05)
sent::Packets::take_ranges: No change in performance detected. time: [8.0690 µs 8.2868 µs 8.4969 µs]
change: [−14.020% +11.427% +55.279%] (p = 0.66 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [37.658 ms 37.746 ms 37.842 ms]
change: [+0.4591% +0.7544% +1.0723%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [38.343 ms 38.454 ms 38.569 ms]
change: [−0.3750% +0.0304% +0.4414%] (p = 0.88 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [37.680 ms 37.759 ms 37.848 ms]
change: [+1.5206% +1.8242% +2.1486%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [38.964 ms 39.069 ms 39.188 ms]
change: [−0.6501% −0.2709% +0.0935%] (p = 0.17 > 0.05)
Download data for |
|
Is there a way to test whether this (1) has caught all the respective functions and (2) something we can do to correctly tag future ones? Also, should we do something similar for types? |
Mark functions not used in Firefox as pub(crate). This enables us to detect unused code and simplifies future refactorings.