Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 51e3ca8

Browse files
committed
Bug 1944631 - Remove the HTTP_RESPONSE_STATUS_CODE histogram that already exists in Glean, r=acreskey,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D236201
1 parent 39278a5 commit 51e3ca8

File tree

2 files changed

+0
-25
lines changed

2 files changed

+0
-25
lines changed

netwerk/protocol/http/nsHttpChannel.cpp

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2564,90 +2564,75 @@ nsresult nsHttpChannel::ProcessResponse() {
25642564
// of auth failures due to Bug 1896350
25652565
switch (httpStatus) {
25662566
case 200:
2567-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 0);
25682567
mozilla::glean::networking::http_response_status_code.Get("200_ok"_ns)
25692568
.Add(1);
25702569
break;
25712570
case 301:
2572-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 1);
25732571
mozilla::glean::networking::http_response_status_code
25742572
.Get("301_moved_permanently"_ns)
25752573
.Add(1);
25762574
break;
25772575
case 302:
2578-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 2);
25792576
mozilla::glean::networking::http_response_status_code
25802577
.Get("302_found"_ns)
25812578
.Add(1);
25822579
break;
25832580
case 304:
2584-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 3);
25852581
mozilla::glean::networking::http_response_status_code
25862582
.Get("304_not_modified"_ns)
25872583
.Add(1);
25882584
break;
25892585
case 307:
2590-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 4);
25912586
mozilla::glean::networking::http_response_status_code
25922587
.Get("307_temporary_redirect"_ns)
25932588
.Add(1);
25942589
break;
25952590
case 308:
2596-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 5);
25972591
mozilla::glean::networking::http_response_status_code
25982592
.Get("308_permanent_redirect"_ns)
25992593
.Add(1);
26002594
break;
26012595
case 400:
2602-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 6);
26032596
mozilla::glean::networking::http_response_status_code
26042597
.Get("400_bad_request"_ns)
26052598
.Add(1);
26062599
break;
26072600
case 401:
2608-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 7);
26092601
mozilla::glean::networking::http_response_status_code
26102602
.Get("401_unauthorized"_ns)
26112603
.Add(1);
26122604
break;
26132605
case 403:
2614-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 8);
26152606
mozilla::glean::networking::http_response_status_code
26162607
.Get("403_forbidden"_ns)
26172608
.Add(1);
26182609
break;
26192610
case 404:
2620-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 9);
26212611
mozilla::glean::networking::http_response_status_code
26222612
.Get("404_not_found"_ns)
26232613
.Add(1);
26242614
break;
26252615
case 421:
2626-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 11);
26272616
mozilla::glean::networking::http_response_status_code
26282617
.Get("421_misdirected_request"_ns)
26292618
.Add(1);
26302619
break;
26312620
case 425:
2632-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 11);
26332621
mozilla::glean::networking::http_response_status_code
26342622
.Get("425_too_early"_ns)
26352623
.Add(1);
26362624
break;
26372625
case 429:
2638-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 11);
26392626
mozilla::glean::networking::http_response_status_code
26402627
.Get("429_too_many_requests"_ns)
26412628
.Add(1);
26422629
break;
26432630
case 500:
2644-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 10);
26452631
mozilla::glean::networking::http_response_status_code
26462632
.Get("other_5xx"_ns)
26472633
.Add(1);
26482634
break;
26492635
default:
2650-
Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_STATUS_CODE, 11);
26512636
if (httpStatus >= 400 && httpStatus < 500) {
26522637
mozilla::glean::networking::http_response_status_code
26532638
.Get("other_4xx"_ns)

toolkit/components/telemetry/Histograms.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2863,16 +2863,6 @@
28632863
"kind": "boolean",
28642864
"description": "Whether or not a new alt-svc mapping would change the target hostname of the existing mapping"
28652865
},
2866-
"HTTP_RESPONSE_STATUS_CODE": {
2867-
"record_in_processes": ["main", "content"],
2868-
"products": ["firefox", "fennec"],
2869-
"alert_emails": ["smayya@mozilla.com"],
2870-
"bug_numbers": [1896350],
2871-
"expires_in_version": "never",
2872-
"kind": "enumerated",
2873-
"n_values": 12,
2874-
"description": "Http response status (0=200, 1=301, 2=302, 3=304, 4=307, 5=308, 6=400, 7=401, 8=403, 9=404, 10=500, 11=other)"
2875-
},
28762866
"HTTP_ONSTART_SUSPEND_TOTAL_TIME": {
28772867
"record_in_processes": ["main", "content"],
28782868
"products": ["firefox", "fennec"],

0 commit comments

Comments
 (0)