Skip to content

Update sql_style.md #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/concepts/sql_style.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,41 @@ WHERE
sample_id = '42'
```

## Comma at the End of the Line

Commas between `SELECT` elements should always be at the end of the line.
For example:

**Good**

```sql
SELECT
client_id,
os_name,
submission_date
FROM
main_summary
WHERE
submission_date > '20180101'
LIMIT
10
```

**Bad**

```sql
SELECT
client_id
, os_name
, submission_date
FROM
main_summary
WHERE
submission_date > '20180101'
LIMIT
10
```

## Nested Queries

Do not use nested queries.
Expand Down