Add WNP-specific theme colors #16312
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've run into some drift between the code-based color tokens and Figma design variables. Design asked if we could align the code values to match Figma and we can do that going forward by adding a theme-colors import to the WNP file. There may be further changes ahead. Once things settle, ideally we can remove this WNP-specific theme coloring and rely on protocol theme colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
Adds optional theme-colors import for light and dark mode WNP pages
Significant changes and points to review
We've run into some drift between the code-based color tokens and Figma design variables. Design asked if we could align the code values to match Figma and we can do that going forward by adding a theme-colors import to the WNP file.
There may be further changes ahead. Once things settle, ideally we can remove this WNP-specific theme coloring and rely on protocol theme colors
Issue / Bugzilla link
n/a - from internal slack discussion
Testing
TBD