Skip to content

Fix product logos in downloads #16291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

janbrasna
Copy link
Contributor

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label. 🤷~ish

One-line summary

Product logos had their parent's box clipped based on font height, this moves the whitespace from outside to inside, to not clip the logo components as the type scale changes…

Significant changes and points to review

There's no change in the box metric with this, with the only exception being it adds a little bottom spacing under the end of every list/section, that I actually find pretty neat. So didn't bother with how to un-collapse whatever is being added there.

This also uses the spacing vars being dynamic across viewports to make the indent smaller on screens that really need to use that space better, so it's moved to a token instead of a fixed size matching the icon in the parent heading exactly.

Issue / Bugzilla link

Fixes #15952

Testing

/firefox/all/ (both desktop and mobile)

@stephaniehobson
Copy link
Contributor

Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (8fe8b99) to head (7c63b7d).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16291      +/-   ##
==========================================
- Coverage   80.12%   80.04%   -0.08%     
==========================================
  Files         158      158              
  Lines        8468     8486      +18     
==========================================
+ Hits         6785     6793       +8     
- Misses       1683     1693      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cropped FF icons on download page
2 participants