Fix product logos in downloads #16291
Draft
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label. 🤷~ishOne-line summary
Product logos had their parent's box clipped based on font height, this moves the whitespace from outside to inside, to not clip the logo components as the type scale changes…
Significant changes and points to review
There's no change in the box metric with this, with the only exception being it adds a little bottom spacing under the end of every list/section, that I actually find pretty neat. So didn't bother with how to un-collapse whatever is being added there.
This also uses the spacing vars being dynamic across viewports to make the indent smaller on screens that really need to use that space better, so it's moved to a token instead of a fixed size matching the icon in the parent heading exactly.
Issue / Bugzilla link
Fixes #15952
Testing
/firefox/all/ (both desktop and mobile)