Load command-line options after loading the config file #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moverest
reviewed
Oct 20, 2025
Yeah, it's not just unintuitive, it's just wrong. Not sure why I did that and then failed to notice. 🤦 |
|
I think the original idea was to be able to chain configuration files so they and the overrides would be read in order and then I moved the file loading after parsing the command line arguments. Oh well. |
jirassimok
force-pushed
the
load-options-later
branch
from
a347110 to
aa77a3f
Compare
|
Freed the extra memory and rebased onto main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, options provided with
-o/--optionare overridden by options in the config file. This is unintuitive and inconvenient.This PR makes the argument-processing loop just collect the options, and then loads them in order after loading the file.
This resolves #62.