Copilot/fix 276 #278
Open
Copilot/fix 276 #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed IOC code generation for anonymous SEQUENCE OF/SET OF types - Added proper type name resolution for element types in IOC context - Added forward declarations for anonymous type descriptors - Anonymous SEQUENCE OF types now generate proper asn_DEF_X_Y_Z references - Resolves compilation errors when using SEQUENCE OF in Information Object Classes Co-authored-by: mouse07410 <5923577+mouse07410@users.noreply.github.com>
Owner
Author
|
@copilot Fix these problems and update PR: |
Owner
Author
|
@copilot requested correction to prevent confusion between type names and include file names has not been applied. Apply it and update this PR |
Owner
Author
|
@copilot remedy this problem is parametrized type code generation: |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compilation issues when handling C2X ASN.1 files containing parametrized objects, specifically addressing problems with anonymous SEQUENCE OF and SET OF types in Information Object Class (IOC) contexts.
- Adds special handling for anonymous SEQUENCE OF and SET OF types within IOC cells
- Generates proper type descriptor names for anonymous collection types using element type and unique index
- Introduces forward declarations for anonymous types to prevent compilation errors
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+305
to
+308
| const char *type_name = asn1c_type_name(arg, cell->value, TNF_SAFE); | ||
| if(strcmp(type_name, "SEQUENCE_OF") == 0 || strcmp(type_name, "SET_OF") == 0) { | ||
| const char *constructor = (cell->value->expr_type == ASN_CONSTR_SEQUENCE_OF) | ||
| ? "SEQUENCE_OF" : "SET_OF"; |
There was a problem hiding this comment.
This code block duplicates the logic from lines 240-247. Consider extracting this into a helper function to avoid code duplication and improve maintainability.
Owner
Author
|
@copilot fix the CI errors and update this PR |
mouse07410
commented
Oct 6, 2025
Owner
Author
mouse07410
left a comment
mouse07410
left a comment
There was a problem hiding this comment.
@copilot apply requested changes to this PR
The logic for determining constructor type is duplicated. The constructor determination should rely on the same condition used in line 241, or use cell->value->expr_type consistently throughout instead of string comparison. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation of C2X ASN.1 file with parametrized objects