Only send the apiKey header in NIST API requests if a NIST_TOKEN is set #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2025 12:49
…e config. The NIST API now always throws an error if a key header is added without a vlid NIST key present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be the case that the NIST API worked just fine if you sent a request with the
apiKeyheader without a key set. Now days, if you add that header to a request with anything other than a valid NIST key the request fails.This PR ensures the
apiKeyheader is added only if a NIST TOKEN is set. This means if the configuration is not changed to add a token, there is noapiKeyheader included and calls will succeed but within the rate limits set by NIST.