Improve CLI and logging output when there is no report or a NIST API error occurs #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2025 12:56
…report. Adding this because otherwise it's not clear CVE Tracker did anything. It just silently terminates.
…ich modules were not successfully searched for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically:
If there are no CVEs there will be report generated. When this occurs, CVE Tracker silently terminates. This causes people who are new to CVE Tracker, or who haven't used it in a while, to wonder if the tool worked at all. This PR adds a new output message to remedy that.
When the NIST search request results in an error response, CVE Tracker failed to check for CVEs in a particular module. There may be CVEs, we just don't know because the query failed. This PR updates the log message used when this error occurs to state the module name that was queried so that a reader of a partial report knows a module is missing solely because the request failed, not because the module is free of CVEs.