Skip to content

Patch 1 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Documentation/AccountMethods.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,20 @@ Post new iceberg order
### Method Signature:

```c#
public async Task<NewOrder> PostNewOrder(string symbol, decimal quantity, decimal price, OrderType orderType, OrderSide side, TimeInForce timeInForce = TimeInForce.GTC, long recvWindow = 6000000)
public async Task<NewOrder> PostNewOrder(string symbol, decimal quantity, decimal price, OrderSide side, OrderType orderType = OrderType.LIMIT, TimeInForce timeInForce = TimeInForce.GTC, decimal icebergQty = 0m, long recvWindow = 5000)
```

## Post test order
Test new order creation and signature/recvWindow long. Creates and validates a new order but does not send it into the matching engine.
### Example:

```c#
var testOrder = binanceClient.PostNewOrderTest("ethbtc", 1m, 0.1m, OrderType.LIMIT, OrderSide.BUY).Result;
var testOrder = binanceClient.PostNewOrderTest("ethbtc", 1m, 0.1m, OrderSide.BUY, OrderType.LIMIT).Result;
```
### Method Signature:

```c#
public async Task<dynamic> PostNewOrderTest(string symbol, decimal quantity, decimal price, OrderType orderType, OrderSide side, TimeInForce timeInForce = TimeInForce.GTC, long recvWindow = 6000000)
public async Task<dynamic> PostNewOrderTest(string symbol, decimal quantity, decimal price, OrderSide side, OrderType orderType = OrderType.LIMIT, TimeInForce timeInForce = TimeInForce.GTC, decimal icebergQty = 0m, long recvWindow = 5000)
```

## Get order
Expand Down
4 changes: 2 additions & 2 deletions Documentation/MarketMethods.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ Get compressed, aggregate trades. Trades that fill at the time, from the same or
### Example:

```c#
var aggregateTrades = binanceClient.GetAggregateTrades("ethbtc").Result;
var aggregateTrades = binanceClient.GetAggregatedTrades("ethbtc").Result;
```
### Method Signature:

```c#
public async Task<IEnumerable<AggregateTrade>> GetAggregateTrades(string symbol, int limit = 500)
public async Task<IEnumerable<AggregateTrade>> GetAggregatedTrades(string symbol, int limit = 500)
```

## Get kline/candlesticks
Expand Down