Cleanup, actions fix, and tags update #261
Conversation
DESCRIPTION
Outdated
| GAMBLR.utils (>= 1.1.1), | ||
| GAMBLR.viz (>= 1.1.1), | ||
| GAMBLR.results (>= 1.1.1), | ||
| GAMBLR.data (>= 1.1), |
There was a problem hiding this comment.
Should these be 1.2 to match remotes below?
There was a problem hiding this comment.
Yeah this is a tag id, not the version - so the one in remotes below should be 1 above what is mentioned here. If they match, the installation complains about incorrect version. In the previous setup, this referred to 1.1.1 for each package and the remotes below were 1 tag above, 1.1.1a/b/c. So similar concept is preserved with the update. It does install the version tagged with 1.2.
README.md
Outdated
|
|
||
| <summary>Which GAMBLR shoud I use?</summary> | ||
|
|
||
| If you are a memeber of the GAMBL consortium (Morin Lab or BC Cancer/CLC with approved access to restricted data), you came to the right place - please follow the instructions in the next section Installation. |
There was a problem hiding this comment.
oups - thanks! Will fix!
README.md
Outdated
| devtools::install_github("morinlab/GAMBLR", repos = BiocManager::repositories()) | ||
| ``` | ||
|
|
||
| This will install the full set of GAMBLR-verse children packages ([GAMBLR.data](https://github.com/morinlab/GAMBLR.data), [GAMBLR.helpers](https://github.com/morinlab/GAMBLR.results), [GAMBLR.utils](https://github.com/morinlab/GAMBLR.utils), [GAMBLR.viz](https://github.com/morinlab/GAMBLR.viz), [GAMBLR.results](https://github.com/morinlab/GAMBLR.results)) with all necessary dependencies. The latter child package ([GAMBLR.results](https://github.com/morinlab/GAMBLR.results)) requires access to the GSC resources and is not intended to be used outside of GSC. If you are interested in standalone functionality, please refer to the documentation of the [GAMBLR.data](https://github.com/morinlab/GAMBLR.data) package or any other individual child package. |
There was a problem hiding this comment.
Consider changing or adding standalone reference to GAMBLR.open rather than GAMBLR.data?
|
Thanks @kmcoyle ! Just pushed the updates to these comments 👍 |
|
Looks good. |
The issues addressed here: