Skip to content

refactor/replace-request-notifications-with-alerts #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

refactor/replace-request-notifications-with-alerts #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions apps/client/src/pages/SessionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,31 +585,8 @@ function SessionPage() {
return user?.id || ''
}

// Request notification permission on component mount
const requestNotificationPermission = async () => {
if ('Notification' in window && Notification.permission === 'default') {
try {
await Notification.requestPermission()
} catch (error) {
console.warn('Failed to request notification permission:', error)
}
}
}

// Show notification when tab is not visible
const showRoomClosedNotification = (message: string) => {
if ('Notification' in window && Notification.permission === 'granted') {
const notification = new Notification('MOQtail Room Closed', {
body: message,
icon: '/moqtail.ico',
requireInteraction: true, // Keep notification visible until user interacts
})

notification.onclick = () => {
window.focus()
notification.close()
}
}
alert(`MOQtail Room Closed: ${message}`)
}

// Check if document is visible
Expand Down Expand Up @@ -1821,9 +1798,6 @@ function SessionPage() {

// Request notification permission and handle page visibility changes
useEffect(() => {
// Request notification permission on mount
requestNotificationPermission()

// Handle page visibility changes to show pending room closed messages
const handleVisibilityChange = () => {
if (!document.hidden && pendingRoomClosedMessage) {
Expand Down
Loading