Skip to content

[docs] Provide full example for Forms API #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fapdash
Copy link
Contributor

@fapdash fapdash commented May 12, 2025

  • provide full example including <?php tag when providing an example file. If an example references a filename the code block should contain a complete example of this file.
  • specify namespace according to the automatic class loading rules
  • add backslash to moodleform for namespaced reference (use moodleform would also be fine)

Not sure if use moodleform is preferred to extends \moodleform. The style guide seems to say that both variants are fine?

Copy link

netlify bot commented May 12, 2025

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 575151b
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6822a9afa3506100086e1397
😎 Deploy Preview https://deploy-preview-1351--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- provide full example including `<?php` tag when providing an example
  file. If an example references a filename the code block should
  contain a complete example of this file.
- specify namespace according to the automatic class loading rules
- add backslash to `moodleform` for namespaced reference
  (`use moodleform` would also be fine)
@andrewnicols andrewnicols force-pushed the provide-full-file-example-form-api branch from 6cb10a5 to 575151b Compare May 13, 2025 02:08
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. I've backported these changes to stables.

@andrewnicols andrewnicols added this pull request to the merge queue May 13, 2025
Merged via the queue into moodle:main with commit 4e44846 May 13, 2025
5 of 6 checks passed
@fapdash fapdash deleted the provide-full-file-example-form-api branch May 13, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants