Load parent configs and try simplified inheritance - followup after MDACH #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Alexander,
here is the promised code that attempts to simplify settings inheritance.
The original idea of settings inheritance was that admins should be able to create pretty much empty classic theme and just add new setting with the same name and load parent settings. Unfortunately when Boost was introduced the devs did not have full understanding of original classic theme architecture it seems.
Anyway, there do not seem to be any new regressions in Github CI compared to pre-existing CI a(you can compare it with https://github.com/skodak/moodle-theme_boost_union_child/actions/runs/17718325253)
I was thinking more about the snippets and sub-plugins, I guess it might be a lot easier approach for most users of your theme to customise their sites with extra code and CSS. I'll try to create a sample patch later this week.
Petr