Add net8.0 and net9.0 support #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for net8.0 and net9.0, reorganizes test projects, and restructures the solution with a new slnx file. Key changes include:
- Adding net8.0 and net9.0 to the target framework lists and updating build properties.
- Moving TaglibSharp.Tests to a new tests folder.
- Creating individual folders and projects for examples alongside a new solution file (.slnx).
Reviewed Changes
Copilot reviewed 378 out of 378 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Debug/Debug.csproj | Removed obsolete Makefile.am removal and streamlined project references. |
| global.json | Configured the SDK version for .NET 9.0 support. |
| examples/StripImageData/*.csproj & .cs | New project configuration and alias usage for TagLib.File. |
| examples/SetPictures/*.csproj & .cs | Adjusted project settings and added file alias for TagLib.File. |
| examples/ReadFromUri/*.csproj | Simplified project configuration by removing unnecessary items. |
| examples/ParsePhoto/*.csproj | New project added. |
| examples/ListSupportedMimeTypes/*.csproj | New project added. |
| examples/GenerateTestFixture/*.csproj & .cs | New project added with redundant dependency removal. |
| examples/BatchSet/*.csproj | New project added. |
| TaglibSharp.slnx | New solution file listing reorganized projects. |
| TaglibSharp.sln | Deprecated legacy solution file (removed). |
| Directory.Packages.props | Enabled central package management and updated package versions. |
| Directory.Build.props | Updated target frameworks, version bump, and added build options. |
| .editorconfig | Changed indent settings and expanded naming/style configuration. |
decriptor
force-pushed
the
dev/sshaw/use-net9
branch
from
edc75d3 to
c248101
Compare
decriptor
force-pushed
the
dev/sshaw/use-net9
branch
2 times, most recently
from
6c4f62f to
9d4efd3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository to support .NET 8.0 and 9.0, restructures example and test projects, migrates from NUnit to MSTest, and modernizes CI/coding conventions.
- Add net8.0 and net9.0 to target frameworks and enable analyzers
- Move tests folder and switch example projects to new SDK-style setup
- Update GitHub Actions to use v4 actions, .NET 9.0, and upload test artifacts
Reviewed Changes
Copilot reviewed 411 out of 411 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Bump version to 2.5.0.0; add net8.0/net9.0 frameworks and analyzers |
| Directory.Packages.props | Centralize package versions; add MSTest and ImageSharp |
| TaglibSharp.slnx | Introduce new slnx solution including examples and tests |
| TaglibSharp.sln | Remove legacy .sln file |
| .github/workflows/*.yml | Upgrade checkout/setup-dotnet actions; target .NET 9.0; upload results |
| .editorconfig | Switch indentation to tabs; add C# style rules |
| examples//.csproj | Convert example projects to SDK-style; remove manual item groups |
| examples//.cs | Add using File = TagLib.File; alias |
| examples/GenerateTestFixture.cs | Replace GLib calls with RunProcess helper and modernize string interpolation |
Comments suppressed due to low confidence (1)
examples/GenerateTestFixture/GenerateTestFixture.cs:21
- [nitpick] Field
md5does not follow PascalCase naming conventions; consider renaming it toMd5or_md5to comply with .NET naming guidelines.
private static MD5 md5 = MD5.Create ();
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="MSTest" Version="3.9.1" /> |
There was a problem hiding this comment.
The MSTest package identifier is ambiguous; consider specifying MSTest.TestFramework and MSTest.TestAdapter packages to ensure test dependencies are correctly resolved.
Suggested change
| <PackageVersion Include="MSTest" Version="3.9.1" /> | |
| <PackageVersion Include="MSTest.TestFramework" Version="3.9.1" /> | |
| <PackageVersion Include="MSTest.TestAdapter" Version="3.9.1" /> |
Copilot uses AI. Check for mistakes.
Previous all of the tmp files were create in the Samples directory. When running tests against multiple runtimes this caused problems. Now the tmp files are written to a subdirectory with the Environment.Version. This isn't a great fix, but it is a workaround for now.
decriptor
force-pushed
the
dev/sshaw/use-net9
branch
from
9d4efd3 to
ed10bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does a few things:
Supersedes #345 #335
Fixes #357
Fixes #252