Skip to content

Conversation

@viveksinghggits
Copy link
Contributor

Summary

In the traditional way of releasing the kubectl plugin when we decompressed the tar, after downloading it from github releases, we directly go the binary and the .sig file. This binary file already had requires permissions to get executed.

But after our last changes to use promotion process to release the kubectl plugin, we unknowingly changed this a little in such a way that

  1. When we decompressed the tar file we got a dir and that dir had the respective binary and .sig file
  2. The binary file didn't have necessary permissions set to get executed.

Because above 2 changes are not required and we would not like to change the way users have been downloading and using the binary, we would like to make sure that they get the same experience. This PR does that. It makes sure that the binary has correct permissions and decompressing the .tar.gz directly gives us binary.

Proof of Work

https://spruce.mongodb.com/version/68fa1efb2a851e0007d34504/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

1. Make `kubectl-mongodb` file executable in git assets
2. Make sure decompressing the file directly gives us the binary
@github-actions
Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.0 Release Notes

New Features

  • MongoDBCommunity: Added support to configure custom cluster domain via newly introduced spec.clusterDomain resource field. If spec.clusterDomain is not set, environment variable CLUSTER_DOMAIN is used as cluster domain. If the environment variable CLUSTER_DOMAIN is also not set, operator falls back to cluster.local as default cluster domain.
  • Helm Chart: Introduced two new helm fields operator.podSecurityContext and operator.securityContext that can be used to configure securityContext for Operator deployment through Helm Chart.

Bug Fixes

  • Fixed parsing of the customEnvVars Helm value when values contain = characters.

Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viveksinghggits viveksinghggits added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Oct 23, 2025
@viveksinghggits viveksinghggits force-pushed the fix-kubectl-plugin-promotion branch from 4b34cf2 to f969d10 Compare October 23, 2025 16:56
@viveksinghggits viveksinghggits merged commit 61dfb1e into master Oct 23, 2025
23 of 24 checks passed
@viveksinghggits viveksinghggits deleted the fix-kubectl-plugin-promotion branch October 23, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants