-
Couldn't load subscription status.
- Fork 22
fix: Community-Operator - Fight with external Pod mutations #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Community-Operator - Fight with external Pod mutations #390
Conversation
Signed-off-by: Mihai Galos <mihai@galos.one>
|
Hi @MaciejKaras, I had a merge problem here. Fixed now. Can you please recheck? Thanks. |
Signed-off-by: Mihai Galos <mihai@galos.one>
bdebd78 to
8fa8fcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix 🙏
|
Hi @m1kola, @anandsyncs. Can you please also have a look at this PR? Thank you. |
|
Up, please |
|
@mihaigalos Could you also create a changelog mentioning your fix? This PR changes the behaviour of Pod labels a little and we need to mention this in Release Notes. More info on how to create changelog and how it is used later -> https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes |
Summary:
This PR mitigates runtime operator fights between mutators of the Pods generated by the MongoDB StatefulSet and the MongoDB Community Operator.
It preserves previous labels instead of hard-coding them. The previous logic of adding the
applabel is kept as-is. The MongoDB operator can still overwrite labels it wants to have in a specific form.All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Closes: mongodb/mongodb-kubernetes-operator#1732.