Added option to configure DEK cache lifetime #1689
Merged
+154
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `AutoEncryptionSettings.Builder#keyExpiration` method and `ClientEncryptionSettings.Builder#keyExpiration` method to configure the cache expiration time for data encryption keys. JAVA-5547
rozza
requested review from
a team and
nhachicha
and removed request for
a team
nhachicha
reviewed
Apr 30, 2025
There was a problem hiding this comment.
LGTM 👍
1- Does this use the updated spec tests? mongodb/specifications@787bbe6
2- What happens when the key expires? Are we testing this via unified or prose test?
mongodb-crypt/src/main/com/mongodb/internal/crypt/capi/MongoCryptOptions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
…yptOptions.java Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>
|
@nhachicha thanks for the review:
Yes 👍
This is handled by libmongocrypt and is covered by unified and their tests |
nhachicha
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
AutoEncryptionSettings.Builder#keyExpirationmethod andClientEncryptionSettings.Builder#keyExpirationmethod to configure the cache expiration time for data encryption keys.JAVA-5547