Tests: Add support for crud tests bypassDocumentationValidation.json #1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
requested review from
a team and
katcharov
and removed request for
a team
katcharov
reviewed
Apr 28, 2025
Comment on lines
171
to
172
| def.skipNoncompliant("Find with batchSize equal to limit - batchSize is set to limit if limit is smaller") | ||
| .test("crud", "find", "Find with batchSize equal to limit"); |
There was a problem hiding this comment.
I'm not sure I understand the rationale - in the test, the limit is not smaller, but is equal to the batchSize. What is the actual expected behaviour in the spec, is it to set batchSize to 1 over the limit, or something else? And why is the driver not doing that?
There was a problem hiding this comment.
Updated - I'm not sure why that was there, must have been an unneeded artifact left over when developing the initial submodule code.
…ns this test isn't failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5827