-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5588: Unable to select KeyValuePair Key when using camelCase convention #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assigned |
// TODO: uncomment the code to demonstrate the fix, revert changes in the test class before merging into the main | ||
// _useCamelCase = true; | ||
|
||
if (_useCamelCase) | ||
{ | ||
var defaultPack = new ConventionPack { new CamelCaseElementNameConvention() }; | ||
ConventionRegistry.Register("camelCase", defaultPack, c => true); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep a permanent tests around this to verify that registered conventions are respected instead of just having this for demonstration. You can just remove the convention once the test is done.
Not sure if we want to keep the test here or do what @rstam usually does which is create a test file with the ticket number and test the particular code the user had as repro code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to have such tests permanently, but not sure if we can. As far as I know there is no way to have multiple serialization registries for now. If I leave the convention pack registered, it will affect all tests that are run after this particular class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.