CSHARP-5547: Remove support for MongoDB 4.0 #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 1, 2025
| @@ -215,6 +215,7 @@ public class Feature | |||
| /// <summary> | |||
| /// Gets the create indexes using insert operations feature. | |||
| /// </summary> | |||
| [Obsolete("This property will be removed in a later release.")] | |||
There was a problem hiding this comment.
Let's communicate the reason for removal (removed in 4.2)?
Like GeoHaystack....
BorisDog
approved these changes
Jul 2, 2025
| @@ -264,13 +264,13 @@ public void Equals_should_return_true_when_all_fields_are_equal() | |||
| [InlineData(new[] { 0, 1 }, false)] | |||
| [InlineData(new[] { 0, 2 }, false)] | |||
| [InlineData(new[] { 0, 6 }, false)] | |||
| [InlineData(new[] { 0, 7 }, true)] | |||
| [InlineData(new[] { 0, 7 }, false)] | |||
There was a problem hiding this comment.
Let's add few cases that were covered by (*, 7), 7 being the first supported. [0, 8], [8, 8]
sanych-sun
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.