CSHARP-5512: Convert LINQ-related tests to use fixtures #1710
Conversation
sanych-sun
changed the title
|
Assigned |
| @@ -15,6 +15,7 @@ | |||
| <NoWarn> | |||
| 1701;1702; <!--https://github.com/dotnet/roslyn/issues/19640--> | |||
| CA1724; <!--The type name Model conflicts in whole or in part with the namespace name. Change either name to eliminate the conflict. (https://docs.microsoft.com/visualstudio/code-quality/ca1724-type-names-should-not-match-namespaces)--> | |||
| CA1714; <!-- Flags enums should have plural names --> | |||
There was a problem hiding this comment.
Are you sure you want to disable this warning project-wide?
There was a problem hiding this comment.
We have to either suppress the warning or rename enums as recommended. I do remember we had similar problem with class named "Model" and we decided to suppress the warning instead of renaming (see line above the commented). But I'm OK with renaming if in this case we do not want to suppress the warning.
There was a problem hiding this comment.
I'm fine with suppressing the warnings, but I think it should be done on a case by case basis instead of project wide.
Are there a lot of these? What motivated you to do it project wide instead of an a case by case basis?
There was a problem hiding this comment.
Found 1 problem so far, suppressed with #pragma
| @@ -15,6 +15,7 @@ | |||
| <NoWarn> | |||
| 1701;1702; <!--https://github.com/dotnet/roslyn/issues/19640--> | |||
| CA1724; <!--The type name Model conflicts in whole or in part with the namespace name. Change either name to eliminate the conflict. (https://docs.microsoft.com/visualstudio/code-quality/ca1724-type-names-should-not-match-namespaces)--> | |||
| CA1714; <!-- Flags enums should have plural names --> | |||
There was a problem hiding this comment.
I'm fine with suppressing the warnings, but I think it should be done on a case by case basis instead of project wide.
Are there a lot of these? What motivated you to do it project wide instead of an a case by case basis?
Another batch of LINQ-related tests converted to use Fixtures.