-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4918: Release notes automation #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions
evergreen/generate-release-notes.sh
Outdated
if [[ "$version" == *.0 ]]; then | ||
template_file="./release-notes.yml" | ||
else | ||
template_file="./patch-notes.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: identation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
evergreen/patch-notes.yml
Outdated
labels: "*" | ||
|
||
- The full list of issues resolved in this release is available at [CSHARP JIRA project](https://jira.mongodb.org/issues/?jql=project%20%3D%20CSHARP%20AND%20fixVersion%20%3D%20${version}%20ORDER%20BY%20key%20ASC). | ||
- Documentation on the .NET driver can be found [here](https://www.mongodb.com/docs/drivers/csharp/v${version}}/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think docs link work for version that includes patch: "3.3.1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
evergreen/release-notes.yml
Outdated
- maintenance | ||
|
||
- The full list of issues resolved in this release is available at [CSHARP JIRA project](https://jira.mongodb.org/issues/?jql=project%20%3D%20CSHARP%20AND%20fixVersion%20%3D%20${version}%20ORDER%20BY%20key%20ASC). | ||
- Documentation on the .NET driver can be found [here](https://www.mongodb.com/docs/drivers/csharp/v${version}/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think docs link work for version that includes patch: "3.3.1".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
evergreen/release-notes.py
Outdated
total_pages = 1 | ||
page_size = 100 | ||
commits_url = "{github_api_base_url}{repo}/compare/{previous_tag}...{version_tag}".format( | ||
github_api_base_url=opts.github_api_base_url, repo=opts.repo, previous_tag=opts.previous_tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: single line to line for each param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
for section in opts.template["sections"]: | ||
if is_in_section(mapped, section): | ||
if mapped in section["items"]: | ||
break # PR was already added to the section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. If we have multiple PRs for single Jira ticket, then it might be already in the list.
evergreen/release-notes.py
Outdated
|
||
for commit in commits["commits"]: | ||
pullrequests_url = "{github_api_base_url}{repo}/commits/{commit_sha}/pulls".format( | ||
github_api_base_url=opts.github_api_base_url, repo=opts.repo, commit_sha=commit["sha"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that we can have multiple PRs for same commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to make it possible, but github API has such model, so I suppose somehow it's possible.
No description provided.