-
Notifications
You must be signed in to change notification settings - Fork 29
Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_ITERABLE #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@WaVEV I used VIRTUAL_COLUMN_PREFIX instead of PREFIX_ITERABLE since I didn't understand that meaning. Tell me if my interpretation doesn't make sense. |
This column represents the iterable used in the map operation over an EMFA. It can refer to a simple column (by name) or to a |
82b2097
to
406ce59
Compare
# of the queried field's type represents each element. | ||
column_target = field.clone() | ||
column_name = f"$item.{field.column}" | ||
column_name = f"${self.VIRTUAL_COLUMN_PREFIX}.{field.column}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget this?
406ce59
to
af74f95
Compare
cleanups identified in #396