Remove unused **extra_context from Aggregates, Add EmbeddedModelArrayFieldTransform.VIRTUAL_COLUMN_ITERABLE #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WaVEV I used VIRTUAL_COLUMN_PREFIX instead of PREFIX_ITERABLE since I didn't understand that meaning. Tell me if my interpretation doesn't make sense. |
This column represents the iterable used in the map operation over an EMFA. It can refer to a simple column (by name) or to a |
timgraham
changed the title
timgraham
force-pushed
the
agg_unused_context
branch
from
82b2097 to
406ce59
Compare
WaVEV
reviewed
Oct 10, 2025
| # of the queried field's type represents each element. | ||
| column_target = field.clone() | ||
| column_name = f"$item.{field.column}" | ||
| column_name = f"${self.VIRTUAL_COLUMN_PREFIX}.{field.column}" |
WaVEV
approved these changes
Oct 10, 2025
timgraham
force-pushed
the
agg_unused_context
branch
from
406ce59 to
af74f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanups identified in #396