feat: reject when no invoke handlers were defined for an event #12
+85
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekomeowww
reviewed
Oct 18, 2025
| function emit<P>(event: Eventa<P>, payload: P, options?: EmitOptions) { | ||
| function emit<P>(event: Eventa<P>, payload: P, options?: EmitOptions): boolean { | ||
| const emittingPayload = { ...event, body: payload } | ||
| let isConsumed = false |
There was a problem hiding this comment.
I am afraid of this may not work as expected since if we are running electron & worker in different threads, the reference to how listener was called are different to how the emit in defineInvoke could get.
I think we might need to add one more event to InvokeEventa and call it as connected or consuming, then at least the peer that emit(s) the event would be able to be aware about whether there is a remote peer consuming the request. Along with the connected or consuming, we can add one more option called comsumingTimout works like how TCP timeout was. (maybe we could think about how we would work with UDP too.)
PS: oh and we could have a UDP adapter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the Promise returned by the invoke function reject when no invoke handlers were defined for the invoke event. This helps avoid producing Promises that never resolve or reject, which may be hard to troubleshoot.