-
-
Notifications
You must be signed in to change notification settings - Fork 348
feat: sink React dependencies and switch to TSC compiler #3919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove React dependencies from root package.json - Move React dependencies to individual packages that need them - Add @types/react to packages using React types - Switch rsbuild-plugin and SDK from SWC to TSC compiler - Fix React.CSSProperties type resolution in bridge-shared 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Add TypeScript path mappings and project references to resolve module federation SDK imports when using TSC instead of SWC. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update @types/react from 18.2.79 to 18.3.11 to resolve jsx-dev-runtime import issues in tests after React dependencies were moved from root to individual packages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update lockfile to reflect @types/react version change in bridge-react package. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Revert rsbuild-plugin from TSC to SWC compiler as TSC has module resolution issues with workspace dependencies in the rollup build process. Keep SDK with TSC as requested. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix jsx-dev-runtime import errors in bridge-react tests - Convert from Vite test runner to @nx/jest:jest executor - Add Jest configuration with SWC transformer - Add React dependency package.json in bridge directory - Update test imports from vitest to @jest/globals - Add TextEncoder/TextDecoder polyfills for jsdom - Configure proper JSX transformation with SWC This resolves the CI failures where bridge-react tests were failing due to "Failed to resolve import 'react/jsx-dev-runtime'" errors. Tests now run successfully with Jest framework. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Changes Made
React Dependency Management
react
,react-dom
,react-router-dom
,@types/react
,@types/react-dom
from root package.jsonpackages/modernjs
- Added@types/react
and@types/react-dom
packages/nextjs-mf
- Added@types/react
and@types/react-dom
packages/utilities
- Added@types/react
and@types/react-dom
packages/bridge/bridge-shared
- Added@types/react
to fix React.CSSProperties usagepackages/bridge/vue3-bridge
- Added@types/react
for bridge-shared dependencyCompiler Changes
packages/rsbuild-plugin/project.json
compiler from "swc" to "tsc"packages/sdk/project.json
compiler from "swc" to "tsc"Test plan
Benefits
🤖 Generated with Claude Code