-
Notifications
You must be signed in to change notification settings - Fork 4
baseline plotting for quickstart #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the contours look a bit different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to quickstart.png? FloPy is managing those contours.
|
||
# create budget reader | ||
bpth = os.path.join(ws, f"{modelname}.bud") | ||
bobj = flopy.utils.CellBudgetFile(bpth, precision="double") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @deltamarnix plans to see if we can swap this and line 46 out with (lazy) output loading routines
grbpth = Path("./quickstart_data/mymodel.dis.grb") | ||
grid = flopy.discretization.StructuredGrid.from_binary_grid_file(grbpth) | ||
|
||
# TODO: get_specific_discharge is dependent on flopy3 model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is where an adapter would be necessary? I guess we could try Gwf
implementing ModelInterface
and implement whichever properties get_specific_discharge
needs, and stub the rest of them for now. Not sure how feasible that would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for get_specific_discharge. I'm not sure if it's worth pursuing now or not. I think we need to discuss more and decide which path we want to be on.
Update quickstart with basic FloPy based plotting
Also add qsplot.py examples as alternatives