Skip to content

baseline plotting for quickstart #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Apr 29, 2025

Update quickstart with basic FloPy based plotting

Also add qsplot.py examples as alternatives

  • Dependent on cartopy, which has not been added with this commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the contours look a bit different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to quickstart.png? FloPy is managing those contours.


# create budget reader
bpth = os.path.join(ws, f"{modelname}.bud")
bobj = flopy.utils.CellBudgetFile(bpth, precision="double")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @deltamarnix plans to see if we can swap this and line 46 out with (lazy) output loading routines

grbpth = Path("./quickstart_data/mymodel.dis.grb")
grid = flopy.discretization.StructuredGrid.from_binary_grid_file(grbpth)

# TODO: get_specific_discharge is dependent on flopy3 model
Copy link
Member

@wpbonelli wpbonelli Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is where an adapter would be necessary? I guess we could try Gwf implementing ModelInterface and implement whichever properties get_specific_discharge needs, and stub the rest of them for now. Not sure how feasible that would be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for get_specific_discharge. I'm not sure if it's worth pursuing now or not. I think we need to discuss more and decide which path we want to be on.

@mjreno mjreno merged commit 98ba19a into modflowpy:develop Apr 29, 2025
11 checks passed
@mjreno mjreno mentioned this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants