DevCenter for Apache Maven org in app.moderne.io #29
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| cardName: Move to the latest `maven-parent` | ||
| groupIdPattern: org.apache.maven | ||
| artifactIdPattern: maven-parent | ||
| version: 45 |
There was a problem hiding this comment.
I initially tried using version: x here, but that lead to all versions being completed, whereas it'd have been nice not to have to pin and update versions here. 🤷🏻
| groupIdPattern: org.apache.maven.shared | ||
| artifactIdPattern: maven-shared-components | ||
| version: 45 | ||
| upgradeRecipe: io.moderne.devcenter.UpgradeMavenSharedParent |
There was a problem hiding this comment.
Picked these three based on a recipe run: https://app.moderne.io/visualizations/Z8RIAHcwt
| - io.moderne.devcenter.JavaVersionUpgrade: | ||
| majorVersion: 17 | ||
| upgradeRecipe: org.openrewrite.java.migrate.UpgradeToJava17 |
There was a problem hiding this comment.
Even thought this card is last, it's odd how it's the third panel, not the fourth.
| description: >- | ||
| A collection of recipes that apply best practices to Maven POMs. | ||
| Some of these recipes affect build stability, so they are reported as security issues in the DevCenter card. |
There was a problem hiding this comment.
It's somewhat unfortunate we can't change the header on the security card, but figured nice to show dedicated goals here, with an appropriate fix.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/io/moderne/devcenter/DevCenter.java
- lines 23-24
- lines 209-210
- src/main/java/io/moderne/devcenter/result/SecurityIssuesReader.java
- lines 52-52
- src/main/java/io/moderne/devcenter/result/UpgradesAndMigrationsReader.java
- lines 52-52
1 participant
With a local run I'm seeing:
Intention is to configure this on the platform org:
https://app.moderne.io/devcenter/next/ALL%2FOpen%20Source%2FNetflix%20%2B%20Spring%20%2B%20Apache%2FApache%2FApache%20Maven
There had been an earlier effort; following a discussion yesterday we think this repository (but separate files clearly documented) would still be the best place for additional dev centers that we want to show in the platform.
I'd briefly considered moving such devcenters to say rewrite-apache, rewrite-micronaut and rewrite-quarkus, but that then quickly complicates that intern-module-dependencies with cycles, and stretches the release train quite a bit.