feat: 3 phase discovery for oauth metadata discovery #797
+163
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are a wide variety of OAuth providers that don't necessarily adhere to strict
RFC 8414
paths for metadata discover. For example, Okta provides their OAuth servers with aoauth2/{id}
path. So your server will look like:where its metadata is discoverable like so:
This change implements a 3 phased metadata discovery fallback:
(Note: this also captures some fixes my editor automatically made for alot of trailing whitespace in
auth.test.ts
)How Has This Been Tested?
Unit tests
Breaking Changes
Fully backwards compatible, no breaking changes, existing tests pass.
Types of changes
Checklist
Additional context
Fixes: #744
Related: modelcontextprotocol/inspector#634