Skip to content

Revert "fix: add type safety for tool output schemas in ToolCallback" #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sushichan044
Copy link
Contributor

Reverts #670

Addressing this issue: #670 (comment)
Forcibly casting a type onto CallToolResult was a bad modification.

@bhosmer-ant bhosmer-ant self-requested a review July 3, 2025 20:55
Copy link
Contributor

@bhosmer-ant bhosmer-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushichan044 my apologize for not realizing the consequence of #670 on tool handlers - I assumed (without exhaustive testing) the optionality of the new type param would preserve backward compatibility.

I haven't thought it through in detail, but it feels plausible that the addition could be made in a backwards-compatible way. Please let me know if you try!

@bhosmer-ant bhosmer-ant merged commit 9879d7a into modelcontextprotocol:main Jul 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants