fix: correct add logic for all vs specific files and add tests (#2373) #2379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
git_add
function to correctly differentiate between staging all files (["."]
) and specific files. Previously, using["."]
could unintentionally include the.git/
directory, potentially corrupting the repository. This fix ensures only appropriate files are staged.It also includes two additional test cases:
["."]
Server Details
Motivation and Context
Fixes #2373
The issue identified that
git_add(files=["."])
was tracking files inside the.git/
directory. This caused repository integrity issues. This PR corrects the logic to avoid touching internal Git files and ensures safe staging behavior.How Has This Been Tested?
.git/
is excluded when staging all filesBreaking Changes
None
Types of changes
Checklist
Additional context
Let me know if there are any changes or improvements you'd like to see. Happy to revise as needed.