Handles message type Exception in lowlevel/server.py _handle_message function. Mentioned as TODO on line 528. #786
Conversation
|
@Kludex I came across TODO mentioned in Would appreciate feedback on how to handle the exception. Since there is no request attached to the message I have sent a log notification response to the client with the error message. |
- Handle exceptions in match statement as suggested by TODO - Use proper dict structure for error logging instead of ErrorData - Add comprehensive tests with parameterization - Include exception type, module, and args in log data Reported-by: AishwaryaKalloli Github-Issue: modelcontextprotocol#786
Initital commit, need feedback.
- Handle exceptions in match statement as suggested by TODO - Use proper dict structure for error logging instead of ErrorData - Add comprehensive tests with parameterization - Include exception type, module, and args in log data Reported-by: AishwaryaKalloli Github-Issue: modelcontextprotocol#786
|
@AishwaryaKalloli thanks for your contribution! Made some tweaks on top of your branch + rebased + added some test cases for exception handling. I don't think we should be using JSONRPC types for log messages, so changed this to a literal dict.gg |
felixweinberger
requested review from
Kludex and
ihrpr
and removed request for
felixweinberger
| "message": str(message), | ||
| "type": type(message).__name__, | ||
| "module": type(message).__module__, | ||
| "args": getattr(message, "args", None), |
There was a problem hiding this comment.
Can we instead pass the values that would be passed to __exit__?
exception_type, exception_value, exception_traceback
I'm assuming passing the data in this shape was your idea? Or do we do this somewhere else already?
Handles message type Exception in lowlevel/server.py _handle_message function.
Right now I am sending a error log if parameter raise_exception=False.
Initital commit, need feedback.
Motivation and Context
Addressing a TODO mentioned in the code, handling one of the unhandled types of message in server.
How Has This Been Tested?
Initial commit, testing pending, need feedback to move ahead.
Breaking Changes
Does not break existing flow. Since the method raises exception it will break the code in case of exception, however it is expected behaviour.
Types of changes
Checklist
Additional context