Add in-memory transport #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-merrill
commented
Nov 5, 2024
jspahrsummers
approved these changes
Nov 5, 2024
mcp_python/client/session.py
Outdated
| @@ -36,8 +36,15 @@ def __init__( | |||
| self, | |||
| read_stream: MemoryObjectReceiveStream[JSONRPCMessage | Exception], | |||
| write_stream: MemoryObjectSendStream[JSONRPCMessage], | |||
| read_timeout_seconds: int | float | None = None, | |||
There was a problem hiding this comment.
TIOLI: Should this be a timedelta to avoid unit errors entirely?
|
sweeeet |
nick-merrill
force-pushed
the
merrill/mcp-memory-transport
branch
from
3849a4d to
5dd79b2
Compare
nick-merrill
commented
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Support running an MCP server in the same process as the client, while preserving MCP abstractions.
Details
(core change) Adds a new
memorytransport module that enables in-process client-server communication.This includes:
create_client_server_memory_streams()to create bidirectional memory streamscreate_connected_server_and_client_session()to establish an in-process client-server connection(minor) Enhances error handling and timeout support:
read_timeout_secondsparameterraise_exceptionsflag to control whether errors are returned to clients or raised directly(minor) Makes server improvements: