fix(fastmcp): propagate mimeType in resource template list #1186
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test - Fix resource template list did not include the mimeType attribute. - Propagate mimeType from template metadata to the list output in FastMCP. - Add test_resource_template_includes_mime_type to verify that listed resource templates include the correct mimeType and the resource is still accessible via the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the mimeType attribute of resource templates was not included in the results of resource template list in FastMCP. The change ensures that clients receive the correct mimeType metadata. Additionally, a dedicated test is added to verify this behaviour and prevent regressions.
Motivation and Context
Previously, when listing resource templates using FastMCP, the returned objects were missing the mimeType field. This omission could lead to clients being unaware of the correct content type associated with a resource, which in turn could cause issues in handling, displaying, or routing resources based on their type. This change ensures that the mimeType is properly propagated and visible in resource template listings, improving correctness and client interoperability.
How Has This Been Tested?
Breaking Changes
No breaking changes. This is a bug fix; the interface for registering or listing resources/templates is unchanged. Only the metadata in the output is more complete.
Types of changes
Checklist
Additional context
This closes a gap where client code consuming list_resource_templates() or similar methods may have been missing MIME type information for templates, which could impact rendering, routing, or file handling logic.
No changes are required for users who register or access resources—the fix is internal and improves the API response consistency.