-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Rename streamablehttp_client
to streamable_http_client
#1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecated wrapper is missing the httpx_client_factory
and auth
parameters. This could break existing code using those parameters.
(it's probably a good time to replace httpx_client_factory with an object)
I blame copilot. 😄 |
I think the timeouts, the auth and the httpx_client_factory CAN be replaced. The timeouts I think can be subjective, but the auth and the httpx_client_factory I think need to be replaced. |
should we just replace it now, since we are deprecating one method, would be good to have a nice alternative and not to deprecate it twice? |
I didn't get what you said. I agree that it's a good moment to change the parameters of the new |
The current name is not very intuitive considering the class name and the module.