Skip to content

fix markdown error in README in main #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
+2 −3
Merged

fix markdown error in README in main #1147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d691b4
fix markdown error in README
ihrpr Jul 15, 2025
b9b1c6b
fix test
ihrpr Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,13 +950,12 @@ By default, SSE servers are mounted at `/sse` and Streamable HTTP servers are mo
The following example shows how to use `streamable_http_app()`, a method that returns a `Starlette` application object.
You can then append additional routes to that application as needed.

```
from starlette.routing import Route
```python
mcp = FastMCP("My App")

app = mcp.streamable_http_app()
# Additional non-MCP routes can be added like so:
# from starlette.routing import Route
# app.router.routes.append(Route("/", endpoint=other_route_function))
Comment on lines +958 to 959
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually bad advice. No one should use app.router.routes...

I think the idea is to mount the ASGI app from FastMCP into an existent Starlette application.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, I'll be re-writing more README today/tomorrow

```

Expand Down
Loading