add type field to client session config BaseModels #1127
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pre-set
type
field toSseServerParameters
,StreamableHttpParameters
, andStdioServerParameters
so serialized parameters will easily be loaded into the correct class.Motivation and Context
All fields of
SseServerParameters
overlap withStreamableHttpParameters
, so a third party application that would want to connect to multiple session with a config such as:would not have a way to be instantiated from a serialized config (like a yaml file) since the following is ambiguous.
Additionally, if someone were to serialize either the sse or http config classes they would not be able to reload the second class listed in the union.
Adding the preset
type
field should fix this in a backwards compatible way.How Has This Been Tested?
Existing tests cover backwards compatibility, confirmed this PR addresses the described use case
Breaking Changes
No, added fields include the only valid Literal default.
Types of changes
Checklist
Additional context