Public API generator #642
Closed
Public API generator #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will take a look at build issues. Converting to a draft for now. |
|
The API surface of the SDK is still unstable. While we'd want to add this eventually, I'm not certain that now is the time to do so. cc @stephentoub |
|
Ok. Let me close this PR then. We can PublicAPI it anytime in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
PublicApiGeneratorso that the public API of three main libs is properly asserted.Motivation and Context
A discussion under #639 showed that there's no assertion over the public API here.
How Has This Been Tested?
Three tests have been added, one for each project being asserted.
Breaking Changes
No. It will prevent the breaking changes from happening unnoticed.
Types of changes
Checklist