Make McpJsonUtilities public and remove IVT to sample #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds in the same encoder used by AIJsonUtilities.
stephentoub
requested review from
eiriktsarpalis and
halter73
and removed request for
eiriktsarpalis and
halter73
| @@ -26,23 +47,31 @@ private static JsonSerializerOptions CreateDefaultOptions() | |||
| // If reflection-based serialization is enabled by default, use it, as it's the most permissive in terms of what it can serialize, | |||
| // and we want to be flexible in terms of what can be put into the various collections in the object model. | |||
| // Otherwise, use the source-generated options to enable trimming and Native AOT. | |||
| JsonSerializerOptions options; | |||
|
|
|||
| if (JsonSerializer.IsReflectionEnabledByDefault) | |||
There was a problem hiding this comment.
I think this is a good stopgap, but longer term we should look at using the source generator everywhere. Whether we can do this or not is a function of allowing user-defined types to be inserted in the DTOs. I don't believe that would be necessary -- the protocol should only deal with closed types.
eiriktsarpalis
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds in the same encoder used by AIJsonUtilities.