Skip to content

Update to Rust edition 2024 #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Member

@tautschnig tautschnig commented Jul 3, 2025

Upstream change rust-lang/rust#143214 (Remove let_chains unstable feature) requires us to either remove the use of let in several places or wholesale update to Rust edition 2024. Doing this edition update seems worthwhile to keep accessing more recent features, but required code changes in several places.

This is in preparation of the toolchain upgrade to 2025-07-03, but does not actually do this upgrade for it will require other, unrelated changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Upstream change rust-lang/rust#143214 (Remove
let_chains unstable feature) requires us to either remove the use of
`let` in several places or wholesale update to Rust edition 2024. Doing
this edition update seems worthwhile to keep accessing more recent
features, but required code changes in several places.

Resolves: model-checking#4196
@tautschnig tautschnig requested a review from a team as a code owner July 3, 2025 11:56
@github-actions github-actions bot added Z-EndToEndBenchCI Tag a PR to run benchmark CI Z-CompilerBenchCI Tag a PR to run benchmark CI labels Jul 3, 2025
@tautschnig tautschnig changed the title Update to Rust edition 2024 and toolchain to 2025-07-03 Update to Rust edition 2024 Jul 3, 2025
Copy link
Contributor

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tautschnig tautschnig added this pull request to the merge queue Jul 4, 2025
Merged via the queue into model-checking:main with commit 173594b Jul 4, 2025
27 of 28 checks passed
@tautschnig tautschnig deleted the toolchain-2025-07-03-manual branch July 4, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-CompilerBenchCI Tag a PR to run benchmark CI Z-EndToEndBenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants