[DRAFT] Resolve stubs and contracts in trait implementations #4130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynzech
force-pushed
the
contracts-qualified-paths
branch
from
5d20982 to
396dfd0
Compare
carolynzech
force-pushed
the
contracts-qualified-paths
branch
6 times, most recently
from
e3edb88 to
b2dfdb5
Compare
the attribute lifetime is tied to TyCtxt, so we should make that explicit
…ct_attribute` to call `resolve_fn_path` and thereby be able to resolve qualified paths, which they can't do in the current impl because `resolve_from_mod` only handled simple paths
carolynzech
force-pushed
the
contracts-qualified-paths
branch
from
b2dfdb5 to
801158c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review; I am testing that it passes CI before writing tests.
Resolves #4084
Resolves #4057
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.