Add support for quantifiers #3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
tautschnig
reviewed
Apr 11, 2025
carolynzech
requested changes
Apr 17, 2025
There was a problem hiding this comment.
I've only looked at the tests so far. I'm not sure that this makes sense to merge if the only kinds of harnesses that we can run are the ones in no_array.rs. IMO the main benefit of quantifiers is quantifying over some collection (array, vector, ...), so we should either block this PR until that's possible, or I would expect to see some expected tests to prove that it works.
Also, can we move the tests to expected and have some assertions about particular properties that are being checked?
tautschnig
reviewed
Apr 17, 2025
tautschnig
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for quantifiers. Especially, we inline function calls in quantified expressions so that the result statement-expression can be accepted by the CBMC backend.
RFC: RFC 0010-quantifiers.
Resolves #2546 and #836.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.