Decrease usage of deprecated elements

[jozic]

@TimvdLippe
i would like to add support for Scala 3, but i also like baby steps, so this is one of the steps towards Scala 3 (and cleaner build). The only usages of deprecated elements left (and suppressed) are from mockito-core, like

    /**
     * @deprecated Not used by Mockito but by mockito-scala
     */
    @Deprecated
    public RealMethod getRealMethod() {
        return realMethod;
    }

all other deprecated warnings are fixed and compiler will not let add new ones without explicitly suppressing them

[TimvdLippe]

These all look good, thanks for cleaning these up! I only have one clarifying question if we are not accidentally dropping JVM 11 support.

[TimvdLippe]

We still support Java 11. Why is this code no longer required to be checked?

[jozic]

It's still good as you can see from checks - we run it in JDK 11 as well.
The old code was also working for versions lower than 11, which we don't need to support now, as 11 is the lowest we support

[TimvdLippe]

Right, but my confusion is as to why the check here is for Java 17 and lower, not 11. Isn't this code still relevant for Java 11 til 16?

[jozic]

I guess that was my mistake as I added that when trying to make it work with JDK 17, this the naming. But it seems like that works fine for JDK 11 as well. At least it runs fine on my local and on CI.

[TimvdLippe]

Okay, let's merge this and hopefully CI coverage is sufficient. If not, we revert the removal when users do run into it after all.