-
Notifications
You must be signed in to change notification settings - Fork 60
Upgrade mockito-core to 5.18.0, add support for JDK 17 and 21, drop Scala 2.11 and JDK 8 #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 small comment. The rest LGTM! Thanks for the fixes.
version.properties
Outdated
version=1.18.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this a 2.0.* release, since we are dropping support for various configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will update
Should we then also drop some long time deprecated methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I guess, we can do that in 2.0.1 as well :)
…cala 2.11 and JDK 8
c248e45
to
0b5b666
Compare
@TimvdLippe bumped version to 2.0.0 |
Right. Let's drop these deprecated methods as well indeed. All of them appear to have appropriate replacements, so it should be doable for users to migrate. Thanks again for all the effort in getting this project up-to-date again |
@TimvdLippe I will send a separate commit to this PR and I suggest we don't squash those commits to keep history clean and easy to navigate |
@TimvdLippe I've dropped all the deprecated methods with replacements, but kept also, not sure why but seems like Gradle wrapper check is unstable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@jozic Seems like by bumping the Java version of the release job to 17, it now fails: https://github.com/mockito/mockito-scala/actions/runs/15277155793/job/42966910185 That's because we still use Gradle 6 (old!). Can you update our Gradle wrapper to the latest version as well and create a new PR? Thanks! |
@TimvdLippe you made the change in #560, right? Also, can you think of a way to automatically check depending projects like mockito-scala, mockito-kotlin, etc when mockito-core is changed? Ideally when PR is opened or at least when a new version is released |
@jozic No I didn't upgrade Gradle. I only upgraded the GitHub action that verifies Gradle according to the checksum. We expect them as normal consumers, e.g. they shouldn't break. Of course that sometimes is more tricky than we would like, but in general we strive to never break our users including our own dependent artifacts. |
fixes #350
fixes #515
fixes #520
fixes #556
closes #517