Skip to content

More README Fixes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

More README Fixes #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ document.getElementById("notificationsSwitch").addEventListener("click", async (
/// Tell the user something went wrong here.
console.error(error);
}
}
});

...
Expand All @@ -330,7 +329,7 @@ export async function registerSubscription(subscription) {
...subscription.toJSON(),
/// It is good practice to provide the applicationServerKey back here so we can track which one was used if multiple were provided during configuration.
applicationServerKey: subscription.options.applicationServerKey,
}
},
});

/// Do something with your registration. Some may use it to store notification settings and display those back to the user.
Expand All @@ -350,7 +349,7 @@ import WebPush

do {
try await manager.send(
json: ["title": "Test Notification", "body": "Hello, World!",
json: ["title": "Test Notification", "body": "Hello, World!"],
to: subscriber
/// If sent from a request, pass the request's logger here to maintain its metadata.
// logger: request.logger
Expand Down