Skip to content

MAINT: Stabilize MxNE tests #13321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

MAINT: Stabilize MxNE tests #13321

merged 1 commit into from
Jul 15, 2025

Conversation

larsoner
Copy link
Member

@Genuster from some testing on SSH I realized it was a Heisenbug -- only showed up on some calls to pytest mne/inverse_sparse -xk sure_meg for example. I am hoping adding these random_state=0s to the simulate_evoked calls fixes the bug. I expect them to. Will merge this either way then merge main into your branch, and we can continue testing there if needed. But hopefully it just comes back green!

@larsoner
Copy link
Member Author

... and this sort of thing can happen when new tests are added, if those tests (or any underlying functions) make use of the global-state-based np.random etc. Hence why I'm pushing commits to #13259 to change some np.random.<func> calls to be np.random.RandomState(0).<meth> calls instead.

@larsoner larsoner mentioned this pull request Jul 15, 2025
16 tasks
@larsoner larsoner merged commit 48f1588 into mne-tools:main Jul 15, 2025
33 of 34 checks passed
@larsoner larsoner deleted the tests branch July 15, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants